Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-docker 19.03 #56466

merged 2 commits into from Feb 28, 2019

nvidia-docker 19.03 #56466

merged 2 commits into from Feb 28, 2019


Copy link

@averelld averelld commented Feb 27, 2019

Motivation for this change

Backport of #51733 (no actual changes, and has been tested with the current release-19.03).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Averell Dalton added 2 commits Feb 27, 2019
nvidia_x11 and persistenced were modified to provide binaries which can be
mounted inside a docker-container to be executed there.

most ldconfig-based discovery of bundled nvidia libraries is patched out

ldconfig itself is patched to be able to deal with patchelf'ed libraries
@averelld averelld requested a review from Infinisil as a code owner Feb 27, 2019
@Infinisil Infinisil merged commit db90ae9 into NixOS:release-19.03 Feb 28, 2019
10 checks passed
@averelld averelld deleted the nv-docker-19.03 branch Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants