Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio: 2019-01-31 -> 2019-02-26 #56475

Merged
merged 1 commit into from Feb 28, 2019
Merged

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Feb 27, 2019

https://github.com/minio/minio/releases/tag/RELEASE.2019-02-26T19-51-46Z
https://github.com/minio/minio/releases/tag/RELEASE.2019-02-20T22-44-29Z (security)
https://github.com/minio/minio/releases/tag/RELEASE.2019-02-14T00-21-45Z
https://github.com/minio/minio/releases/tag/RELEASE.2019-02-12T21-58-47Z (critical)
https://github.com/minio/minio/releases/tag/RELEASE.2019-02-06T21-16-36Z

Motivation for this change

Critical and security updates, see list of release notes above.

Should check at least NixOS minio test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
bachp approved these changes Feb 28, 2019
@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

@GrahamcOfBorg test minio

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

Darwin failure looks unrelated.

@xeji xeji merged commit 569c594 into NixOS:master Feb 28, 2019
15 checks passed
15 checks passed
minio on x86_64-darwin Failure
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
minio on aarch64-linux Success
Details
minio on x86_64-linux Success
Details
tests.minio on aarch64-linux Success
Details
tests.minio on x86_64-linux Success
Details
@fpletz
Copy link
Member

@fpletz fpletz commented Mar 2, 2019

If you merge updates that fix security issues like this please either backport them yourself or label is as security and let the security team deal with it. Only found this by chance. Backported now.

@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.