Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_12: init at go 1.12 #56500

Merged
merged 2 commits into from Mar 4, 2019
Merged

Conversation

@kalbasit
Copy link
Member

kalbasit commented Feb 28, 2019

Motivation for this change

The build cache is now required as a step toward eliminating $GOPATH/pkg. Setting the environment variable GOCACHE=off will cause go commands that write to the cache to fail. I've updated all the packages that I could find and are using go without using buildGoPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS (sandbox off)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested with

λ nix run -f '<nixpkgs>' nur.repos.kalbasit.nix-verify -c nix-verify -I nixpkgs=`pwd` \
        -A bazel-watcher \
        -A boringssl \
        -A cadvisor \
        -A cide \
        -A cni-plugins \
        -A deepin.dbus-factory \
        -A deepin.dde-api \
        -A deepin.dde-daemon \
        -A deepin.deepin-desktop-base \
        -A deepin.deepin-desktop-schemas \
        -A deepin.deepin-metacity \
        -A deepin.deepin-wallpapers \
        -A deepin.deepin-wm \
        -A deepin.go-dbus-generator \
        -A deepin.go-gir-generator \
        -A docker \
        -A docker-gc \
        -A gitlab-shell \
        -A gitlab-workhorse \
        -A go \
        -A go_1_11 \
        -A gometalinter \
        -A kubectl \
        -A kubectx \
        -A kubernetes \
        -A pipework \
        -A prometheus \
        -A prometheus-alertmanager \
        -A prometheus-pushgateway \
        -A prometheus_2 \
        -A python37Packages.jupyter-repo2docker \
        -A rkt \
        -A singularity \
        -A tmsu \
        -A vault \
        -A vgo2nix \
        -A vimPlugins.vim-go
@kalbasit

This comment has been minimized.

Copy link
Member Author

kalbasit commented Feb 28, 2019

@GrahamcOfBorg build bazel-watcher boringssl cadvisor cide cni-plugins deepin.dbus-factory deepin.dde-api deepin.dde-daemon deepin.deepin-desktop-base deepin.deepin-desktop-schemas deepin.deepin-metacity deepin.deepin-wallpapers deepin.deepin-wm deepin.go-dbus-generator deepin.go-gir-generator docker docker-gc gitlab-shell gitlab-workhorse go go_1_11 gometalinter kubectl kubectx kubernetes pipework prometheus prometheus-alertmanager prometheus-pushgateway prometheus_2 python37Packages.jupyter-repo2docker rkt singularity vault vgo2nix vimPlugins.vim-go

@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_add-support-go-1-12 branch from c6bcc3b to 91479b6 Mar 2, 2019
@kalbasit kalbasit marked this pull request as ready for review Mar 2, 2019
@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_add-support-go-1-12 branch from 91479b6 to 6ef04ca Mar 2, 2019
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 3, 2019

The checksum error on darwin should be fixed though:

@GrahamcOfBorg build go_1_12

I suspect it might be a related to case-insenstive filesystem again.

@kalbasit

This comment has been minimized.

Copy link
Member Author

kalbasit commented Mar 3, 2019

@Mic92 I suspect that it is, as well. I tested the entire PR on Darwin myself, but unlike ofborg I’m running APPFS.

fetchFromGitHub and thus fetchzip hashes the contents of the archive and
not the archive itself. Unicode file names lead to different checksums
on HFS+ vs. other file systems because of Unicode normalisation
@kalbasit kalbasit force-pushed the kalbasit:nixpkgs_add-support-go-1-12 branch from 6fed306 to 252376c Mar 4, 2019
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 4, 2019

@GrahamcOfBorg build go_1_12

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 4, 2019

This was the only package that failed to build on my machine.
Let's say what ofborg produces:

@GrahamcOfBorg build prometheus
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 4, 2019

The last darwin build error just look like resource depletion. I think we can ignore this given that you already build on macOS.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 4, 2019

This was the build error log of prometheus: https://dl.thalheim.io/RRa5YdOzO7l0jKJ1cV01aA/prometheus.log

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Mar 4, 2019

Ok. Maybe this was caused by my zfs filesystem or some other random stuff.

@Mic92 Mic92 merged commit 27cb066 into NixOS:master Mar 4, 2019
16 checks passed
16 checks passed
go_1_12 on x86_64-darwin Failure
Details
prometheus on x86_64-darwin Failure
Details
go_1_12 on aarch64-linux Success
Details
go_1_12 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
prometheus on aarch64-linux Success
Details
prometheus on x86_64-linux Success
Details
@kalbasit kalbasit deleted the kalbasit:nixpkgs_add-support-go-1-12 branch Mar 4, 2019
@dicarlo2

This comment has been minimized.

@kalbasit This line needs to be in the below string as well so that the variable is exported on darwin.

This comment has been minimized.

Copy link
Member Author

kalbasit replied Mar 10, 2019

@dicarlo2 good catch, thank you! I filed #57296 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.