Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
llvm/7/compiler-rt: define CMAKE_*_COMPILER_TARGET unconditionally #56502
When building with -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON the compiler-rt
Motivation for this change
Fixes regression from #55750.
When building with -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON the compiler-rt CMake configuration attempts to use CMAKE_*_COMPILER_TARGET variables, which are usually only defined in cross-compilation mode.
<3 okay great. hostPlatfrom from targetPackages, that's the part I was missing. Anyway better safe than sorry, and thanks for the explanation :).…
On Wed, 27 Feb 2019 20:54:58 -0800, Matthew Bauer ***@***.***> wrote: Yeah, compiler-rt is a runtime library so it should be hostPlatform. We want it to be taken from targetPackages like the libc is. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #56502 (comment) part: text/html