Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: add vim-sneak, unicode.vim, nvim-hs.vim, far.vim, vim-rsi #56503

Merged
merged 6 commits into from Apr 14, 2019

Conversation

@teto
Copy link
Contributor

teto commented Feb 28, 2019

There is a warning with unicode.vim not being able to write/cache results but it works. Might need some upstream changes.

Motivation for this change

it's a pain to download unicode data as I have netrw disabled.
vim-sneak is very convenient

Waiting for #56191 to be able to update plugins,

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto

This comment has been minimized.

Copy link
Contributor Author

teto commented Mar 11, 2019

I fixed the issue with unicode.vim (the author released a new version that fixed the problem).
The order of the commit is not the best maybe but generated.nix does contain far-vim.
Ready to merge hopefully.

@teto teto force-pushed the teto:vimPlugins branch 2 times, most recently from c6810dd to 09060c7 Mar 20, 2019
@teto teto force-pushed the teto:vimPlugins branch from 09060c7 to b37122d Apr 6, 2019
@teto teto changed the title vimPlugins: adding vim-sneak,unicode.vim, nvim-hs.vim vimPlugins: adding vim-sneak,unicode.vim, nvim-hs.vim [RDY] Apr 10, 2019
@teto teto mentioned this pull request Apr 12, 2019
1 of 10 tasks complete
Copy link
Member

timokau left a comment

Would you mind adding the versions the individual plugins are initialized at to the commite (init at 2019-xx-xx)? I know its a bit of a nitpick, but its the way we usually do it and shouldn't be much effort with a git rebase -i.

While you're at it you could also add one more commit to update all the plugins to the latest versions, replacing #59343.

Otherwise LGTM.

@teto teto force-pushed the teto:vimPlugins branch from b37122d to 9522051 Apr 12, 2019
@timokau timokau changed the title vimPlugins: adding vim-sneak,unicode.vim, nvim-hs.vim [RDY] vimPlugins: add vim-sneak, unicode.vim, nvim-hs.vim, far.vim, vim-rsi Apr 12, 2019
Copy link
Member

timokau left a comment

Sorry for sending you through another iteration, but nix-review fails:

nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/timo/.cache/nix-review/pr-56503/build.nix
builder for '/nix/store/fpl1jfng1pa0skfjpk2qpy70vwx3i1y0-vimplugin-nvim-hs-vim-2019-01-05.drv' failed with exit code 1; last 10 log lines:
  unpacking sources
  unpacking source archive /nix/store/nkfkjw60szwv9c83ci8311lz26k6ixv9-source
  source root is source
  patching sources
  configuring
  building
  installing
  Building help tags
  Error detected while processing command line:
  E154: Duplicate tag "nvim-hs" in file /nix/store/8hskf9qs40h426hbyxgvxkjrxhlk6nzi-vimplugin-nvim-hs-vim-2019-01-05/share/vim-plugins/nvim-hs-vim/doc/nvim-hs.txtFailed to build help tags!
pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
@teto teto force-pushed the teto:vimPlugins branch 2 times, most recently from 95532ab to 68f65d4 Apr 12, 2019
@teto

This comment has been minimized.

Copy link
Contributor Author

teto commented Apr 13, 2019

i tried to address your reviews

@timokau

This comment has been minimized.

Copy link
Member

timokau commented Apr 13, 2019

nix-review still reports the same build failure of nvim-hs-vim though.

@teto teto force-pushed the teto:vimPlugins branch from 68f65d4 to a8a5114 Apr 14, 2019
@teto

This comment has been minimized.

Copy link
Contributor Author

teto commented Apr 14, 2019

I filed an issue for nvim-hs-vim and dropped it from this PR. The current darwin failure seems unrelated and due to a nixpkgs master darwin failure if I trust the recent issues.

@timokau

This comment has been minimized.

Copy link
Member

timokau commented Apr 14, 2019

Thank you :)

@timokau timokau merged commit 3f901ea into NixOS:master Apr 14, 2019
14 checks passed
14 checks passed
vimPlugins.far-vim, vimPlugins.unicode-vim, vimPlugins.vim-rsi, vimPlugins.vim-sneak on x86_64-darwin Timed out, unknown build status
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.far-vim, vimPlugins.unicode-vim, vimPlugins.vim-rsi, vimPlugins.vim-sneak on aarch64-linux Success
Details
vimPlugins.far-vim, vimPlugins.unicode-vim, vimPlugins.vim-rsi, vimPlugins.vim-sneak on x86_64-linux Success
Details
@teto teto deleted the teto:vimPlugins branch Apr 14, 2019
@teto

This comment has been minimized.

Copy link
Contributor Author

teto commented Apr 14, 2019

that's a super cool merge thanks.

@timokau

This comment has been minimized.

Copy link
Member

timokau commented Apr 14, 2019

You're welcome. You are doing good work and are generally responsive to reviews. It's a shame this PR was left to bitrot for so long.

Feel free to ping me in the future if one of your PRs is ready for merge (i.e. at least passes ofBorg and nix-review) and you think I'd be qualified to review. No guarantees of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.