Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aiounifi: init at 4 + a few other minor updates to satisfy HA #56508

Closed
wants to merge 5 commits into from
Closed

python3Packages.aiounifi: init at 4 + a few other minor updates to satisfy HA #56508

wants to merge 5 commits into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

ffmpeg and unifi components broke with HA 0.87.1

Cc: @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from FRidh as a code owner February 28, 2019 06:17
@peterhoeg peterhoeg mentioned this pull request Feb 28, 2019
Merged
10 tasks
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 28, 2019
dotlambda
dotlambda requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cherry pick the pyupdate bump from staging-next and then apply yours so we don't have merge conflicts later on. The pyunifi and ha-ffmpeg bumps should also be cherry picked from there.

pkgs/top-level/python-packages.nix
unifi = callPackage ../development/python-modules/unifi { };

pyunifi = callPackage ../development/python-modules/pyunifi { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be ordered somewhat alphabetically.

pkgs/development/python-modules/aiounifi/default.nix
@@ -0,0 +1,26 @@
{ stdenv, buildPythonPackage, fetchPypi, isPy3k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, buildPythonPackage, fetchPypi, isPy3k
{ lib, buildPythonPackage, fetchPypi, isPy3k

pkgs/development/python-modules/aiounifi/default.nix
# upstream has no tests
doCheck = false;

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@dotlambda
Copy link
Member

included in #55383

@dotlambda dotlambda closed this Mar 2, 2019
@peterhoeg peterhoeg deleted the p/aiounifi branch March 4, 2019 01:35
@peterhoeg peterhoeg restored the p/aiounifi branch March 4, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterhoeg @dotlambda @GrahamcOfBorg