Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.aiounifi: init at 4 + a few other minor updates to satisfy HA #56508

Closed
wants to merge 5 commits into from

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Feb 28, 2019

Motivation for this change

ffmpeg and unifi components broke with HA 0.87.1

Cc: @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Please cherry pick the pyupdate bump from staging-next and then apply yours so we don't have merge conflicts later on. The pyunifi and ha-ffmpeg bumps should also be cherry picked from there.

unifi = callPackage ../development/python-modules/unifi { };

pyunifi = callPackage ../development/python-modules/pyunifi { };

This comment has been minimized.

@dotlambda

dotlambda Feb 28, 2019
Member

This should still be ordered somewhat alphabetically.

@@ -0,0 +1,26 @@
{ stdenv, buildPythonPackage, fetchPypi, isPy3k

This comment has been minimized.

@dotlambda

dotlambda Feb 28, 2019
Member

Suggested change
{ stdenv, buildPythonPackage, fetchPypi, isPy3k
{ lib, buildPythonPackage, fetchPypi, isPy3k
# upstream has no tests
doCheck = false;

meta = with stdenv.lib; {

This comment has been minimized.

@dotlambda

dotlambda Feb 28, 2019
Member

Suggested change
meta = with stdenv.lib; {
meta = with lib; {
@dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 2, 2019

included in #55383

@dotlambda dotlambda closed this Mar 2, 2019
@peterhoeg peterhoeg deleted the peterhoeg:p/aiounifi branch Mar 4, 2019
@peterhoeg peterhoeg restored the peterhoeg:p/aiounifi branch Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.