Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #56408 mess (runtimeShell) #56509

Merged
merged 4 commits into from Feb 28, 2019
Merged

fix #56408 mess (runtimeShell) #56509

merged 4 commits into from Feb 28, 2019

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 28, 2019

Motivation for this change

https://hydra.nixos.org/build/89668091

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Mic92 @Ericson2314 You owe me one! It's sad I have to clean up after you.

@dotlambda dotlambda merged commit c2f358e into NixOS:master Feb 28, 2019
10 of 12 checks passed
Loading
@dotlambda
Copy link
Member Author

@dotlambda dotlambda commented Feb 28, 2019

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants