Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mercury: build on Darwin #56511

Merged
merged 1 commit into from Feb 28, 2019
Merged

mercury: build on Darwin #56511

merged 1 commit into from Feb 28, 2019

Conversation

@jacereda
Copy link
Contributor

@jacereda jacereda commented Feb 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 28, 2019

@GrahamcOfBorg build mercury

Loading

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

timed out on darwin, let's try one more
@GrahamcOfBorg build mercury

Loading

@jacereda
Copy link
Contributor Author

@jacereda jacereda commented Feb 28, 2019

Mercury is quite big and the build takes a while. I'd say it took something like half an hour on my laptop.

Loading

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

Timed out again, so let's merge this and see if it builds on Hydra.

Loading

@xeji xeji merged commit bf3a38a into NixOS:master Feb 28, 2019
13 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants