Skip to content

lndir: get rid of xorgproto dependency #56516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

lndir: get rid of xorgproto dependency #56516

merged 1 commit into from
Mar 1, 2019

Conversation

jacereda
Copy link
Contributor

To put it in context:

#56066

xeji
xeji previously requested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR on the staging branch as it triggers a mass rebuild.

@jacereda jacereda changed the base branch from master to staging February 28, 2019 23:12
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Feb 28, 2019
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 28, 2019
@xeji
Copy link
Contributor

xeji commented Mar 1, 2019

@GrahamcOfBorg build xorg.lndir

vcunat
vcunat approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, checked the C stuff. Assuming Borg checks build on Darwin.

@vcunat vcunat merged commit 466f1d8 into NixOS:staging Mar 1, 2019
vcunat added a commit that referenced this pull request Mar 1, 2019
@vcunat
Merge #56516: lndir: get rid of xorgproto dependency
dfa45df 
... into staging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@xeji xeji xeji left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacereda @xeji @vcunat @GrahamcOfBorg