Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.mnist: init at 0.2.2 #56518

Merged
merged 2 commits into from Nov 22, 2019
Merged

pythonPackages.mnist: init at 0.2.2 #56518

merged 2 commits into from Nov 22, 2019

Conversation

@dmrauh
Copy link
Contributor

@dmrauh dmrauh commented Feb 28, 2019

Motivation for this change

Add python mnist utilities.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 28, 2019

@GrahamcOfBorg build python2.pkgs.mnist python3.pkgs.mnist

@dotlambda dotlambda changed the title mnist: init at 0.2.2 pythonPackages.mnist: init at 0.2.2 Feb 28, 2019
Copy link
Member

@dotlambda dotlambda left a comment

Please add yourself to maintainer-list.nix in a separate commit and change the commit message of the existing one to the PR's title.

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or, if there are no tests, set doCheck = false and add a comment with the reason.

Finally, please make the python2 build work.

pkgs/development/python-modules/mnist/default.nix Outdated Show resolved Hide resolved
@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch 2 times, most recently from 2077059 to 2eb21c1 Feb 28, 2019
@aanderse
Copy link
Contributor

@aanderse aanderse commented Aug 5, 2019

@dmrauh are you able to address the comments above and continue with this PR?

@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch from 2eb21c1 to 13b526a Oct 17, 2019
@dmrauh
Copy link
Contributor Author

@dmrauh dmrauh commented Oct 17, 2019

Please excuse my long hiatus. I hope that i have addressed all comments. The only problem i had was that some tests using sockets during check phase were failing which i had to disable in the end.

@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch 3 times, most recently from f8e1299 to cdca919 Oct 17, 2019
@dmrauh
Copy link
Contributor Author

@dmrauh dmrauh commented Oct 22, 2019

@dotlambda @aanderse do you think my PR can be merged or is there anything else to do?

@aanderse
Copy link
Contributor

@aanderse aanderse commented Oct 22, 2019

@dmrauh I don't see any issues. Thanks for following up. @dotlambda good to go from your perspective?

@aanderse aanderse requested a review from dotlambda Nov 12, 2019
@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch from cdca919 to 8f947e3 Nov 22, 2019
@dmrauh dmrauh requested a review from jonringer as a code owner Nov 22, 2019
@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch from 8f947e3 to c437761 Nov 22, 2019
@dmrauh dmrauh force-pushed the dmrauh:add/mnist branch from c437761 to 3097a72 Nov 22, 2019
Copy link
Contributor

@jonringer jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/56518
3 package were built:
python27Packages.mnist python37Packages.mnist python38Packages.mnist
@jonringer jonringer merged commit 3936a48 into NixOS:master Nov 22, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dmrauh
Copy link
Contributor Author

@dmrauh dmrauh commented Nov 22, 2019

Thanks to all reviewers for your help!

@dmrauh dmrauh deleted the dmrauh:add/mnist branch Nov 22, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019

... it did take 8 months... that's quite a while. what's impressive to me, is that this means we've had 17k PRs in 8 months, which is averaging like 2.1k a month O.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.