Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: fix Google Calendar synchronization #56520

Closed
wants to merge 1 commit into from

Conversation

@dpaetzel
Copy link
Contributor

dpaetzel commented Feb 28, 2019

Motivation for this change

Google calendar support is currently broken in vdirsyncer (pimutils/vdirsyncer#765). There exists a PR at vdirsyncer for that (pimutils/vdirsyncer#788) but they are really slow to respond—thus this PR which adds the patch right away.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dpaetzel dpaetzel changed the title vdirsyncer: fix Google calendar synchronization vdirsyncer: fix Google Calendar synchronization Feb 28, 2019
@dpaetzel dpaetzel force-pushed the dpaetzel:fix-vdirsyncer-google branch from a944c49 to 5ad7553 Feb 28, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from jgeerds Feb 28, 2019
@dpaetzel

This comment has been minimized.

Copy link
Contributor Author

dpaetzel commented Feb 28, 2019

Why the down vote? I'm really interested in your opinion—did I make a mistake?

@erictapen

This comment has been minimized.

Copy link
Contributor

erictapen commented Feb 28, 2019

@GrahamcOfBorg build vdirsyncer

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Feb 28, 2019

Why the down vote? I'm really interested in your opinion—did I make a mistake?

You didn't make a mistake. It's just that I'm not sure if we should force this patch down the throat of every NixOS user given that you admit not to be familiar with the code and given that the code seems to deal with certificate validation.
This patch seems rather easy to find and aplly using overrideAttrs for everyone with the problem.

PS: I admit I'm also not the biggest fan of patches to make proprietary services that aren't standards-compliant work.

@dpaetzel

This comment has been minimized.

Copy link
Contributor Author

dpaetzel commented Feb 28, 2019

I'm not sure if we should force this patch down the throat of every NixOS user given that you admit not to be familiar with the code and given that the code seems to deal with certificate validation.
This patch seems rather easy to find and aplly using overrideAttrs for everyone with the problem.

OK, you're probably right there.

PS: I admit I'm also not the biggest fan of patches to make proprietary services that aren't standards-compliant work.

I agree with that. I hate to still have to use Google Calendar (but I cannot—yet—change that).

@dpaetzel dpaetzel closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.