Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: 1.13.3 -> 1.13.4 #56524

Merged
merged 1 commit into from Feb 28, 2019
Merged

kubernetes: 1.13.3 -> 1.13.4 #56524

merged 1 commit into from Feb 28, 2019

Conversation

@johanot
Copy link
Contributor

johanot commented Feb 28, 2019

Motivation for this change

@GrahamcOfBorg build kubernetes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 28, 2019

@GrahamcOfBorg test kubernetes.dns

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 28, 2019

@GrahamcOfBorg test kubernetes.rbac

@xeji xeji merged commit b8285fc into NixOS:master Feb 28, 2019
16 checks passed
16 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kubernetes on aarch64-linux Success
Details
kubernetes on x86_64-linux Success
Details
tests.kubernetes.dns on aarch64-linux Success
Details
tests.kubernetes.dns on x86_64-linux Success
Details
tests.kubernetes.rbac on aarch64-linux Success
Details
tests.kubernetes.rbac on x86_64-linux Success
Details
@johanot johanot mentioned this pull request Feb 28, 2019
5 of 10 tasks complete
xeji added a commit that referenced this pull request Feb 28, 2019
@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Feb 28, 2019

backported to 19.03 in 2a53812

fpletz added a commit to mayflower/nixpkgs that referenced this pull request Mar 7, 2019
(cherry picked from commit b8285fc)
(cherry picked from commit 2a53812)
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jun 16, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/kubernetes-broken-on-master-a-recurring-event/3191/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.