Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libplist: 2018-07-25 -> 2019-01-20 #56529

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

@dtzWill dtzWill commented Mar 4, 2019

While looking at packages using this, noticed spacefm has comment mentioning it has a workaround for libplist not building? Well it builds now (and possibly before, didn't check)! :)

Loading

@dtzWill dtzWill merged commit 094a204 into NixOS:master Mar 7, 2019
13 checks passed
Loading
@dtzWill dtzWill deleted the update/libplist-2019-01-20 branch Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants