Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typora: 0.9.64 -> 0.9.65 #56533

Closed
wants to merge 2 commits into from
Closed

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Feb 28, 2019

Motivation for this change

new version, changelog
(may need to scroll to find this version in the future):

https://typora.io/windows/dev_release.html

(yes, "windows" in URL is what the Linux page links to)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dtzWill added 2 commits Feb 21, 2019
Touchup script.
@@ -15,16 +15,12 @@ stdenv.mkDerivation rec {

unpackPhase = "dpkg-deb -x $src .";

dontWrapGApps = true;

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Feb 28, 2019

Member

Not disabling this will produce two wrappers, that's why I inject gappsWrappersArgs[@] below.

However I was doing the wrapping in the wrong phase, and should be in postFixup.
Think that will fix the crash.

worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Mar 31, 2019
Also make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in NixOS#56533

Closes NixOS#56533
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Mar 31, 2019
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in NixOS#56533

Closes NixOS#56533
@worldofpeace worldofpeace mentioned this pull request Mar 31, 2019
4 of 10 tasks complete
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Mar 31, 2019
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in NixOS#56533

Closes NixOS#56533
worldofpeace added a commit that referenced this pull request Mar 31, 2019
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in #56533

Closes #56533

(cherry picked from commit f54b496)
Fixes crash on in certain places due to an incomplete wrapper.
peterhoeg added a commit to peterhoeg/nixpkgs that referenced this pull request Apr 1, 2019
Make the wrapping happen in postFixup
or else the wrapper is incomplete.
That was noted in NixOS#56533

Closes NixOS#56533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.