Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: 1.13.3 -> 1.13.4 #56543

Closed

Conversation

@johanot
Copy link
Contributor

@johanot johanot commented Feb 28, 2019

Motivation for this change

Backport of #56524

RBAC and DNS tests run without issues locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

@johanot thank you. In general there is no need to open a new PR for a simple backport. Just mention in the original PR that it should be backported. We prefer to git cherry-pick -x from master to the release branch because that makes it easier to track the changes.

@xeji
Copy link
Contributor

@xeji xeji commented Feb 28, 2019

backported in 2a53812

@xeji xeji closed this Feb 28, 2019
@johanot
Copy link
Contributor Author

@johanot johanot commented Feb 28, 2019

Great @xeji thanks!

@johanot johanot deleted the johanot:kubernetes-1.13.4-backport branch Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.