Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redmine: 3.4.8 -> 3.4.9 & 4.0.1 -> 4.0.2 #56557

Merged
merged 1 commit into from
Mar 2, 2019
Merged

redmine: 3.4.8 -> 3.4.9 & 4.0.1 -> 4.0.2 #56557

merged 1 commit into from
Mar 2, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 1, 2019 •
edited
Loading

Motivation for this change

Minor version bump. I guess technically at this point this is a 19.03 backport as well.

http://www.redmine.org/projects/redmine/wiki/Changelog_3_4
http://www.redmine.org/projects/redmine/wiki/Changelog_4_0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Mar 1, 2019 •
edited
Loading

@GrahamcOfBorg test redmine.redmine_3 redmine.redmine_4

@GrahamcOfBorg GrahamcOfBorg requested a review from garbas March 1, 2019 02:13
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 1, 2019
@aanderse
Copy link
Member Author

aanderse commented Mar 1, 2019 •
edited
Loading

Note: doesn't build on aarch64-linux because of recurring issues with darcs, unrelated to this PR

@aanderse
Copy link
Member Author

aanderse commented Mar 2, 2019

@7c6f434c mind taking a look at this PR?

As mentioned above a cherry pick to 19.03 would also be appreciated.

@7c6f434c 7c6f434c merged commit 7093aa5 into NixOS:master Mar 2, 2019
7c6f434c added a commit that referenced this pull request Mar 2, 2019
@7c6f434c
Merge pull request #56557 from aanderse/redmine-pkg-update
98215e4 
redmine: 3.4.8 -> 3.4.9 & 4.0.1 -> 4.0.2
(cherry picked from commit 7093aa5)
@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2019

I guess with some imagination I can indeed stretch this as a data integrity (URL escaping!) fix… 98215e4

@aanderse aanderse deleted the redmine-pkg-update branch March 2, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanderse @7c6f434c @GrahamcOfBorg