Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpqxx: 6.3.1 -> 6.3.3 #56663

Merged
merged 2 commits into from
Mar 4, 2019
Merged

libpqxx: 6.3.1 -> 6.3.3 #56663

merged 2 commits into from
Mar 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Mar 2, 2019
Closed
10 tasks
@GrahamcOfBorg GrahamcOfBorg requested a review from edolstra March 2, 2019 07:56
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 2, 2019
@dtzWill dtzWill merged commit 8c0cd1a into NixOS:master Mar 4, 2019
@dtzWill dtzWill deleted the update/libpqxx-6.3.3 branch March 4, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzWill @GrahamcOfBorg