Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli: 1.16.106 -> 1.16.116 #56671

Closed
wants to merge 1 commit into from
Closed

awscli: 1.16.106 -> 1.16.116 #56671

wants to merge 1 commit into from

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Mar 2, 2019 •
edited
Loading

Fix #56613 broken build by rolling forward and ensuring the versions are
according to the botocore/boto3 dependencies in the awscli setup.py

Motivation for this change

Currently awscli build is broken on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@terlar
awscli: 1.16.106 -> 1.16.116
52d8cbc 
Fix NixOS#56613 broken build by rolling forward and ensuring the versions are
according to the botocore/boto3 dependencies in the awscli setup.py
@terlar terlar requested a review from FRidh as a code owner March 2, 2019 08:31
@FRidh
Copy link
Member

FRidh commented Mar 2, 2019

I just reverted the two commits both here and on 19.03.

@terlar
Copy link
Contributor Author

terlar commented Mar 2, 2019 •
edited
Loading

Oh, okay, I will close this then, thanks.

@terlar terlar closed this Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terlar @FRidh