Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus: remove gconf dependency from runtime #56715

Merged
merged 1 commit into from
Mar 5, 2019
Merged

ibus: remove gconf dependency from runtime #56715

merged 1 commit into from
Mar 5, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 2, 2019

Motivation for this change

wrapGAppsHook adds gconf to runtime even though we only need gsettings-schema-convert utility during build.

This decreases the closure size 514M → 394M

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
ibus: remove gconf dependency from runtime
f577861 
wrapGAppsHook adds gconf to runtime even though we only need
gsettings-schema-convert utility during build.

This decreases the closure size 514M → 394M
@jtojnar jtojnar added the 6.topic: closure size The final size of a derivation, including its dependencies label Mar 2, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 2, 2019
@jtojnar jtojnar merged commit b2b29d2 into NixOS:master Mar 5, 2019
@jtojnar jtojnar deleted the ibus-no-gconf branch March 5, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras Awaiting requested review from lukateras

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
Picking up garbage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @GrahamcOfBorg