Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: fix removed aliases; fix OfBorg eval #56728

Merged
merged 1 commit into from
Mar 2, 2019
Merged

haskell: fix removed aliases; fix OfBorg eval #56728

merged 1 commit into from
Mar 2, 2019

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Mar 2, 2019 •
edited
Loading

Motivation for this change

Fix master eval. Looks like pkgs.gnome3.gtk doesn't exist anymore, so we need to fix this hackage-packages update.

cc @peti @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm ryantm requested review from basvandijk and peti as code owners March 2, 2019 20:51
@jtojnar
Copy link
Member

jtojnar commented Mar 2, 2019

I would just fix it manually in before we update the cabal2nix.

@jtojnar
Copy link
Member

jtojnar commented Mar 2, 2019

See NixOS/cabal2nix#410

@peti
Copy link
Member

peti commented Mar 2, 2019 via email

@ryantm ryantm changed the title Revert "hackage-packages.nix: automatic Haskell package set update" haskell: fix removed aliases; fix OfBorg eval Mar 2, 2019
@ryantm
Copy link
Member Author

ryantm commented Mar 2, 2019

Okay, I fixed eval, but I'm not sure I fixed it correctly. @jtojnar

@jtojnar
Copy link
Member

jtojnar commented Mar 2, 2019

Otherwise it looks fine.

@ryantm ryantm merged commit b0fa740 into NixOS:master Mar 2, 2019
@jtojnar
Copy link
Member

jtojnar commented Mar 2, 2019

Thanks.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Mar 2, 2019
@ryantm ryantm deleted the fix-eval branch August 8, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantm @jtojnar @peti @GrahamcOfBorg