Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mate: cleanup #56774

Merged
merged 2 commits into from
Mar 5, 2019
Merged

nixos/mate: cleanup #56774

merged 2 commits into from
Mar 5, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Someone in IRC noticed that they couldn't execute gsettings because it wasn't installed, and other issue with mate.

Mostly cleand up some cruft like setting XCURSOR_PATH, deferring configuration to enabling gnome3 modules, and adding some things to environment.systemPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from infinisil as a code owner March 3, 2019 09:18
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Mar 3, 2019 •
edited
Loading

Hmm, arch linux uses a systemd service for xdg-user-dirs-update instead of the xdg autostart.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 3, 2019
@worldofpeace
Copy link
Contributor Author

Forgot to enable programs.dconf. Fixed that.

@infinisil infinisil merged commit 09c3fb0 into NixOS:master Mar 5, 2019
@worldofpeace worldofpeace deleted the mate/cleanup branch March 5, 2019 21:36
@worldofpeace
Copy link
Contributor Author

Thanks for the review @infinisil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@worldofpeace @infinisil @GrahamcOfBorg