Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torrential: init at 1.1.0 #56784

Merged
merged 1 commit into from
Mar 5, 2019
Merged

torrential: init at 1.1.0 #56784

merged 1 commit into from
Mar 5, 2019

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented Mar 3, 2019

Motivation for this change

Add a torrent client which is well integrated with the Pantheon Desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xiorcale xiorcale changed the title torrential: init at 1.1.1 torrential: init at 1.1.0 Mar 3, 2019
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 3, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 3, 2019
@worldofpeace worldofpeace added the 6.topic: pantheon The Pantheon desktop environment label Mar 3, 2019
@worldofpeace worldofpeace self-assigned this Mar 3, 2019
@worldofpeace worldofpeace mentioned this pull request Mar 3, 2019
Closed
10 tasks
@worldofpeace worldofpeace merged commit 72f4a86 into NixOS:master Mar 5, 2019
@worldofpeace
Copy link
Contributor

Thanks @Kjuvi 😄

@xiorcale xiorcale deleted the torrential-init-at-1.1.0 branch March 5, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees

@worldofpeace worldofpeace

Labels
6.topic: pantheon The Pantheon desktop environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiorcale @worldofpeace @GrahamcOfBorg