Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2: remove aliases #56791

Merged
merged 2 commits into from
Mar 5, 2019
Merged

gnome2: remove aliases #56791

merged 2 commits into from
Mar 5, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 3, 2019

Motivation for this change

cc @hedning @ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested review from basvandijk and peti as code owners March 3, 2019 21:55
@jtojnar
Copy link
Member Author

jtojnar commented Mar 3, 2019

Maybe the weird scoping was what caused haskell2nix to pick aliases from gnome2 instead of pkgs.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 3, 2019
@jtojnar jtojnar force-pushed the gnome2-noaliases branch from 9f75070 to b6e4f7d Compare March 5, 2019 14:35
@jtojnar jtojnar force-pushed the gnome2-noaliases branch from b6e4f7d to 57c745f Compare March 5, 2019 14:37
@jtojnar jtojnar merged commit 57c745f into NixOS:master Mar 5, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Mar 5, 2019
@jtojnar jtojnar deleted the gnome2-noaliases branch March 5, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Picking up garbage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @GrahamcOfBorg