Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.resampy: Fix build #56844

Merged
merged 2 commits into from
Mar 5, 2019
Merged

pythonPackages.resampy: Fix build #56844

merged 2 commits into from
Mar 5, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes resampy. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 4, 2019 20:40
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python3Packages.resampy pythonPackages.resampy

worldofpeace
worldofpeace approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just enabled tests there for you @knedlsepp.

Thanks for the fix ❇️

@worldofpeace
Copy link
Contributor

Just checking one more time on the builder, already built it locally.

@GrahamcOfBorg build python3Packages.resampy pythonPackages.resampy

@worldofpeace worldofpeace merged commit dcd3a10 into NixOS:master Mar 5, 2019
@worldofpeace
Copy link
Contributor

Backported in 98a9e8f f33e380

@knedlsepp
Copy link
Member Author

Thanks!

@knedlsepp knedlsepp deleted the fix-resampy branch March 5, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knedlsepp @worldofpeace @GrahamcOfBorg