-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openafs: Add support for Linux 5.0 to openafs_1_8 #56859
Conversation
OpenAFS 1.8.2 does has not yet merged support for Linux 4.20 or 5.0 This patch cherry-picks commits from the git repository, and includes them in the patches/ directory. This also replaces the amalgamated Linux 4.20 patches I added earlier with the original outputs from `git show`. This has been tested to build on Linux 4.4, 4.14, 4.20, and 5.0. This does not change the derivations of openafs_1_8, only linuxPackages_*.openafs_1_8.
cc @spacefrogg |
@GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 Edit, oops, I can't do this. Can someone else run this for me? |
@artemist You might need to add yourself to known-users by opening a PR against https://github.com/NixOS/ofborg @GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 |
@GrahamcOfBorg build linuxPackages_5_0.openafs_1_8 |
I can remove the patches from the new directory I created like I did in #56862, although IMHO it looks cleaner with all 3 patches in a directory (it was cleaner without the dir with 1.6 though) |
Looks good to me. I have no particular opinion on going with or without a patches/ directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works. Most kernels build:
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.openafs_1_8 linuxPackages_hardkernel_latest.openafs_1_8
4 package failed to build:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest-libre.openafs_1_8
linuxPackages_latest_hardened.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8
10 package were build:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_19.openafs_1_8
linuxPackages_4_20.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8
linuxPackages_5_0.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8
linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8
Thank you! |
OpenAFS 1.8.2 does has not yet merged support for Linux 4.20 or 5.0 This patch cherry-picks commits from the git repository, and includes them in the patches/ directory. This also replaces the amalgamated Linux 4.20 patches I added earlier with the original outputs from `git show`. This has been tested to build on Linux 4.4, 4.14, 4.20, and 5.0. This does not change the derivations of openafs_1_8, only linuxPackages_*.openafs_1_8.
Motivation for this change
OpenAFS 1.8.2 does has not yet merged support for Linux 4.20 or 5.0
Things done
This patch cherry-picks commits from the git repository, and includes
them in the patches/ directory. This also replaces the amalgamated Linux 4.20
patches I added earlier with the original outputs from
git show
.This has been tested to build on Linux 4.4, 4.14, 4.20, and 5.0.
This does not change the derivations of openafs_1_8, only
linuxPackages_*.openafs_1_8.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)