-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openafs: fix OpenAFS 1.6 on Linux 4.20 #56862
Conversation
This patch cherry-picks commits from the OpenAFS git repository using `git show` to add support for Linux 4.20 for OpenAFS 1.6. There do not seem to be patches in the Git repository for full Linux 5.0 support, although I have added the ones which exist so far. This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to fail on Linux 5.0. It does not change the drv of the openafs package, only linuxPackages_*.openafs.
cc @spacefrogg |
@GrahamcOfBorg build linuxPackages_4_20.openafs Edit, oops, I can't do this. Can someone else run this for me? |
@GrahamcOfBorg build linuxPackages_4_20.openafs |
@GrahamcOfBorg build linuxPackages_4_20.openafs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds against most kernels (except hardened). Works.
@artemist Thanks for the effort! Looks good from my side. |
@veprbl That's an annoying issue with struct layout randomization. i'm writing a patch I'll submit upstream after some testing, but it's out of scope for this PR (and quite possibly nixpkgs) |
openafs: fix OpenAFS 1.6 on Linux 4.20 This patch cherry-picks commits from the OpenAFS git repository to add support for Linux 4.20 to OpenAFS 1.6. There do not seem to be patches in the Git repository for full Linux 5.0 support, although I have added the ones which exist so far. This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to fail on Linux 5.0. It does not change the drv of the openafs package, only linuxPackages_*.openafs.
Motivation for this change
I have been requested to add linuxPackages_latest support to OpenAFS 1.6. I found working patches, although not enough for 5.0
Things done
This patch cherry-picks commits from the OpenAFS git repository using
git show
to add support for Linux 4.20 for OpenAFS 1.6.There do not seem to be patches in the Git repository for full Linux 5.0
support, although I have added the ones which exist so far.
This patch has been tested on Linux 4.4, 4.14, 4.20, and is confirmed to
fail on Linux 5.0. It does not change the drv of the openafs package,
only linuxPackages_*.openafs.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)