Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bash: fix root prompt #56880

Merged
merged 1 commit into from
Mar 8, 2019
Merged

nixos/bash: fix root prompt #56880

merged 1 commit into from
Mar 8, 2019

Conversation

lheckemann
Copy link
Member

Motivation for this change

b4b6717 introduced a regression of
its own: the prompt would end with $ for all users, not with # for
root as it should.

This should be backported to 19.03, and I'll do so when it's merged (unless the merger beats me to it!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann
nixos/bash: fix root prompt
efbd24f 
b4b6717 introduced a regression of
its own: the prompt would end with $ for all users, not with # for
root as it should.
@lheckemann lheckemann requested a review from infinisil as a code owner March 5, 2019 12:31
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 5, 2019
@infinisil
Copy link
Member

@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 8, 2019
@infinisil infinisil merged commit 6c81f41 into NixOS:master Mar 8, 2019
@infinisil
Copy link
Member

Cherry-picked to 19.03 in 37b1058 :)

@lheckemann lheckemann deleted the bash-root-prompt-fix branch March 8, 2019 06:02
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56880 from mayflower/bash-root-prompt-fix
2c16f0a 
nixos/bash: fix root prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lheckemann @infinisil @GrahamcOfBorg