pythonPackages.isort: 4.3.4 -> 4.3.15

[kwohlfahrt]

We set $TMPDIR, because isort refuses to run in paths containing
'build' (since that is part of Python's typical build infrastructure).

Motivation for this change

Version bump.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[xeji]

@GrahamcOfBorg eval

[dotlambda]

This should be put inside the expression: disabled = !isPy3k. However, I don't think we can afford to drop Python 2 support right now.

[dotlambda]

Actually, I don't see any hint at isort only supporting Python 3. Do you?

[kwohlfahrt]

This was in the release notes a while back: https://github.com/timothycrosley/isort/releases/tag/4.3.5

It might still work from coincidence, so I can switch it on again? AFAIK isort is mostly used as a CLI application, so it doesn't really matter what python version it supports.

[kwohlfahrt]

Why do some packages use callPackage ./whatever.nix { disabled = isPy3k; }, and some use disabledIf isPy3k (callPackage ./whatever.nix)? protobuf uses the former, zeitgeist uses the latter.

[dotlambda]

The latter is only there because it has been for some time. It should no longer be used.

The reason that we cannot simply drop Python 2 support is that there is quite a number of packages that depend on isort or pytest-isort. What you could do is use

isort = if isPy3k then
  callPackage ... { }
else
   callPackage ... { };

[kwohlfahrt]

Ah, OK. So I should pin the old version for use in python 2?

[kwohlfahrt]

Wait, only protobuf uses the disabled = ... syntax, everything else uses disabledIf - or am I missing something?

[dotlambda]

Ah, OK. So I should pin the old version for use in python 2?

Yes, please use the latest version with Python 2 support for that.

Wait, only protobuf uses the disabled = ... syntax, everything else uses disabledIf - or am I missing something?

grep -r "disabled =" pkgs/development/python-modules/ yields quite a lot of results.

[dotlambda]

Even though we now have two expressions, please do still add disabled = !isPy3k to default.nix.

[kwohlfahrt]

Ah, I was looking in top-level/python-packages.nix. Done.

[dotlambda]

There should be two commits with the following commit messages:

• pythonPackages.isort: 4.3.4 -> 4.3.16
• pythonPackages.isort: pin python2-compatible version

[kwohlfahrt]

Squashed, added link and disabled attribute.

[dotlambda]

Please mind the pythonPackages. prefix that should be added to commit messages when it comes to Python packages.

[dotlambda]

The tests for the Python 2 variant are failing:

@GrahamcOfBorg build python2.pkgs.isort

[dotlambda]

Strange, I got

builder for '/nix/store/cm8qmxfbl5b96wjmn08pkgb76kxcby1n-python2.7-pytest-isort-0.3.1.drv' failed with exit code 1; last 10 log lines:
  E           and: u'=========================== 1 passed in 0.02 seconds ==========================='
  E           and: u''
  E       remains unmatched: '*test_incorrectly_sorted*FAILED*'
  
  /build/pytest-isort-0.3.1/test_isort.py:123: Failed
  ========================== deprecated python version ===========================
  You are using Python 2.7.15, which will no longer be supported in pytest 5.0
  For more information, please read:
    https://docs.pytest.org/en/latest/py27-py34-deprecation.html
  ====================== 1 failed, 8 passed in 0.85 seconds ======================

locally. Still investigating why.

[dotlambda]

Ah I see. That's pytest-isort :D My fault.
Still, we'll have to investigate that because it would cause much breakage.

[kwohlfahrt]

Weirdly, rolling back to 4.3.4 for python 2 doesn't work - the same test still fails:

  version = "4.3.4";

  src = fetchPypi {
    inherit pname version;
    sha256 = "1y0yfv56cqyh9wyg7kxxv9y5wmfgcq18n7a49mp7xmzka2bhxi5r";
  };

[dotlambda]

I just came across PyCQA/isort#904. So there's no need to use a different version for Python 2.

[kwohlfahrt]

Removed python-2 specific version. There was a failing test, but for some reason it is passing in upstream CI, so I haven't dug into it much.

[kwohlfahrt]

Addressed all comments.

[dotlambda]

@GrahamcOfBorg build python2.pkgs.pytest-isort python3.pkgs.pytest-isort

[dotlambda]

Nice, it works! 🎉
Thanks a lot for bearing with me @kwohlfahrt!

[dotlambda]

This broke cssselect2, so I disabled the useless tests.

[kwohlfahrt]

Yay! Thanks for looking after this PR - isort was incompatible with black before (i.e. they'd revert each other's changes) so it's nice to have this in.