Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.7.12 -> 0.7.13 #56886

Merged
merged 2 commits into from
Mar 5, 2019
Merged

zfs: 0.7.12 -> 0.7.13 #56886

merged 2 commits into from
Mar 5, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 5, 2019 •
edited
Loading

(cherry picked from commit b57080d34136fd8dcc49632696ceb5ed1ff73326)

Motivation for this change

cc @clefru regarding your question, personally I found rebasing a patch with
git easier then having a patch file in nixpkgs itself.
However we could also move the zfs fork to a more official place, what do you think?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
zfs: 0.7.12 -> 0.7.13
2bfd19f 
(cherry picked from commit b57080d34136fd8dcc49632696ceb5ed1ff73326)
@Mic92
Copy link
Member Author

Mic92 commented Mar 5, 2019

@GrahamcOfBorg test zfs

@Mic92
Copy link
Member Author

Mic92 commented Mar 5, 2019

Mhm. now that I run the tests I get a build error.

@Mic92 Mic92 changed the title zfs: 0.7.12 -> 0.7.13 [WIP] zfs: 0.7.12 -> 0.7.13 Mar 5, 2019
@Mic92
Copy link
Member Author

Mic92 commented Mar 5, 2019

Ah, spl also needs an upgrade.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 5, 2019
@markuskowa
Copy link
Member

duplicate #56882?

@Mic92
Copy link
Member Author

Mic92 commented Mar 5, 2019

Yeah. Also I still prefer git because it is easier to update.

@Mic92 Mic92 changed the title [WIP] zfs: 0.7.12 -> 0.7.13 zfs: 0.7.12 -> 0.7.13 Mar 5, 2019
@Mic92
Copy link
Member Author

Mic92 commented Mar 5, 2019

Tests run on my machine.

markuskowa
markuskowa approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the test runs successfully.

@Mic92 Mic92 merged commit 756e7cd into NixOS:master Mar 5, 2019
@Mic92 Mic92 deleted the zfs-0.7.13 branch March 5, 2019 16:52
@Mic92 Mic92 mentioned this pull request Mar 5, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mic92 @markuskowa @GrahamcOfBorg