Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtwebkit-plugins: fix hunspell build issue #56925

Merged
merged 1 commit into from
Mar 6, 2019
Merged

qtwebkit-plugins: fix hunspell build issue #56925

merged 1 commit into from
Mar 6, 2019

Conversation

stephengroat
Copy link
Contributor

Motivation for this change

fix build issue

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from abbradar March 5, 2019 23:51
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 5, 2019
@stephengroat
Copy link
Contributor Author

fixing breaking build, see https://hydra.nixos.org/build/89542372/nixlog/1

@veprbl
Copy link
Member

veprbl commented Mar 6, 2019

@GrahamcOfBorg build libsForQt511.qtwebkit-plugins
@GrahamcOfBorg build libsForQt512.qtwebkit-plugins

veprbl
veprbl approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to squash the two commits.

@stephengroat
Copy link
Contributor Author

@veprbl no worries, squashed

@veprbl veprbl merged commit 38ee199 into NixOS:master Mar 6, 2019
@stephengroat stephengroat deleted the patch-2 branch March 6, 2019 20:39
veprbl pushed a commit that referenced this pull request Mar 6, 2019
@stephengroat @veprbl
qtwebkit-plugins: fix build for different hunspell version (#56925)
186557e 
(cherry picked from commit 38ee199)
@veprbl
Copy link
Member

veprbl commented Mar 6, 2019

@stephengroat Thank you!

backported: 186557e

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
qtwebkit-plugins: fix build for different hunspell version (NixOS#56925)
ddf9b21
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
qtwebkit-plugins: fix build for different hunspell version (NixOS#56925)
c7f6f1d 
(cherry picked from commit 38ee199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephengroat @veprbl @GrahamcOfBorg