Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shelldap: init at 1.4.0 #56933

Merged
merged 3 commits into from Jun 12, 2019

Conversation

@tobiasBora
Copy link
Contributor

commented Mar 6, 2019

Motivation for this change

Integrate the tool shelldap (that let you browse in shelldap like in a shell).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Show resolved Hide resolved pkgs/top-level/all-packages.nix Outdated
Show resolved Hide resolved pkgs/top-level/perl-packages.nix Outdated

@tobiasBora tobiasBora force-pushed the tobiasBora:master branch from 970697c to 7339d87 Mar 6, 2019

@kalbasit

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@GrahamcOfBorg build shelldap perlPackages.TermShell

@kalbasit

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

@GrahamcOfBorg build shelldap

@kalbasit

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Darwin build is failing:

ld: unknown option: -mmacosx-version-min=10.10
Couldn't execute ld HASCOMPILERhT0p/TESTHrUY.o -o HASCOMPILERhT0p/TESTHrUY.bundle  -mmacosx-version-min=10.10 -bundle -undefined dynamic_lookup -L/no-such-path/lib -fstack-protector-strong : Inappropriate ioctl for device at Makefile.PL line 8.
Sorry! YAML::Syck requires a compiler in order to be built.

@LnL7 thoughts on why it's failing?

@tobiasBora

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@kalbasit : It still does not compile? Any idea how I can at least try to compile it on mac as I don't have a mac? Or maybe we can first just use it for linux only?

@tobiasBora

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@GrahamcOfBorg build shelldap

@kalbasit

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Not sure how to make this work for Mac. You'll have to debug on a Mac machine. Can you scope to Linux only for now so we can get it merged?

Show resolved Hide resolved pkgs/tools/misc/shelldap/default.nix
Show resolved Hide resolved pkgs/tools/misc/shelldap/default.nix Outdated
Show resolved Hide resolved pkgs/tools/misc/shelldap/default.nix Outdated
};
buildInputs = [ ModuleBuild ];
propagatedBuildInputs = [ TermReadKey TextAutoformat ];
meta = {

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg May 28, 2019

Member

with stdenv.lib

This comment has been minimized.

Copy link
@volth

volth May 28, 2019

Contributor

perhaps ModuleBuild is not needed as buildPerlModule adds it.
LGTM, anyway, cpan2nix will fix perl-packages.nix issues on the next run

This comment has been minimized.

Copy link
@tobiasBora

tobiasBora Jun 5, 2019

Author Contributor

I added with stdenv.lib, and removed the ModuleBuild (even if I think cpan2nix added it for me, but not sure anymore). Thanks!

@tobiasBora tobiasBora force-pushed the tobiasBora:master branch 2 times, most recently from 1e5a310 to 25cbc08 Jun 5, 2019

@tobiasBora

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Ok, so I disabled the compilation for mac as I don't have any mac to test, and I applied the change requested. It should build now.

@tobiasBora tobiasBora force-pushed the tobiasBora:master branch from 25cbc08 to 611f848 Jun 6, 2019

@tobiasBora tobiasBora force-pushed the tobiasBora:master branch from 611f848 to e7ed305 Jun 11, 2019

@kalbasit

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@GrahamcOfBorg build shelldap perlPackages.TermShell

@kalbasit kalbasit merged commit 6f4578a into NixOS:master Jun 12, 2019

16 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perlPackages.TermShell, shelldap on aarch64-linux Success
Details
perlPackages.TermShell, shelldap on x86_64-darwin Success
Details
perlPackages.TermShell, shelldap on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.