Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsepol: 2.7 -> 2.8 #56960

Closed
wants to merge 1 commit into from
Closed

libsepol: 2.7 -> 2.8 #56960

wants to merge 1 commit into from

Conversation

outergod
Copy link
Contributor

@outergod outergod commented Mar 6, 2019

Motivation for this change

Update libsepol to 2.8, required to fix NixOS/nix#2374.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Mar 6, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@GrahamcOfBorg GrahamcOfBorg requested a review from Phreedom March 6, 2019 15:22
ryantm
ryantm requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this causes a mas rebuild on Linux, please change the target to the staging branch.

@outergod outergod changed the base branch from master to staging March 7, 2019 10:04
@outergod
Copy link
Contributor Author

outergod commented Mar 7, 2019

@ryantm target changed.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 7, 2019
@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2019
@outergod outergod force-pushed the pkgs/libsepol-2.8 branch from cc384de to 557f719 Compare March 7, 2019 10:13
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 7, 2019
@ryantm
Copy link
Member

ryantm commented Mar 7, 2019

@GrahamcOfBorg build libsepol

@FRidh
Copy link
Member

FRidh commented Mar 10, 2019

@e-user please put these commits in a single PR considering they're connected.

@outergod
Copy link
Contributor Author

Closing in favor of merged PR #56965.

@outergod outergod closed this Mar 10, 2019
@outergod outergod deleted the pkgs/libsepol-2.8 branch March 10, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@outergod @ryantm @FRidh @GrahamcOfBorg