Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefitool: init at A55 and 0.27.0 #57034

Merged
merged 1 commit into from Jan 6, 2020
Merged

uefitool: init at A55 and 0.27.0 #57034

merged 1 commit into from Jan 6, 2020

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 7, 2019

default to new-engine

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 15, 2019

Why do you want to init at 0.26.0 aka "old-engine"? It seems like this could be much simpler if we just wrote the derivation for one version.

@ajs124 ajs124 force-pushed the ajs124:uefitool branch from 09e86d3 to 3a8c740 Mar 15, 2019
@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Mar 15, 2019

Good question. The old engine has some feature which the new one does not, see here.

However, I seem to have forgotten to install the relevant binaries to actually make use of those features. The version I pushed now fixes that.

Edit: This (potentially) replaces #45963

pkgs/tools/system/uefitool/common.nix Outdated Show resolved Hide resolved
pkgs/tools/system/uefitool/common.nix Outdated Show resolved Hide resolved
@ajs124 ajs124 force-pushed the ajs124:uefitool branch 2 times, most recently from 1e59e2e to 87befcb Jan 5, 2020
default to new-engine
@ajs124 ajs124 force-pushed the ajs124:uefitool branch from 87befcb to 65a2c70 Jan 5, 2020
@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Jan 5, 2020

@ryantm fixed. Plus fallout from #65399, because apparently I did that wrong.

@ryantm
ryantm approved these changes Jan 6, 2020
@ryantm ryantm changed the title uefitool: init at A55 and 0.26.0 uefitool: init at A55 and 0.27.0 Jan 6, 2020
@ryantm ryantm merged commit fbd0f1d into NixOS:master Jan 6, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
uefitool on aarch64-linux Success
Details
uefitool on x86_64-linux Success
Details
@ajs124 ajs124 mentioned this pull request Jan 6, 2020
4 of 8 tasks complete
@ajs124 ajs124 deleted the ajs124:uefitool branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.