Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsd: init at 0.13.0 #57116

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@marsam
Copy link
Contributor

marsam commented Mar 9, 2019

Motivation for this change

Add lsd https://github.com/Peltoche/lsd

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Member

worldofpeace left a comment

Builds, functions properly.

Tested completions for bash successfully when installed with nix-env.
However they didn't work with zsh or fish.

@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Mar 11, 2019

Thanks for your review!

However they didn't work with zsh or fish.

I used the completions paths which are commonly used in other nix expressions:
https://github.com/nixos/nixpkgs/blob/c08f80839fc2dda8bfde1f4fd08b08d0403ae487/pkgs/applications/misc/ddgr/default.nix#L21-L24
https://github.com/nixos/nixpkgs/blob/c08f80839fc2dda8bfde1f4fd08b08d0403ae487/pkgs/tools/misc/fd/default.nix#L21-L24

I personally use bash, but I've tested on zsh and seems to be working
image

@ryantm ryantm merged commit e59fe20 into NixOS:master Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lilyball

This comment has been minimized.

Copy link
Contributor

lilyball commented Mar 15, 2019

I just failed to build this on macOS.

> nix build -f . lsd
builder for '/nix/store/47k8sc0hlqgp7pj00rwwdcaxx8gj9qkb-lsd-0.13.0.drv' failed with exit code 101; last 10 log lines:
  thread 'meta::filetype::test::test_socket_type' panicked at 'failed to create the socket: Custom { kind: InvalidInput, error: StringError("path must be shorter than SUN_LEN") }', src/libcore/result.rs:1009:5
  note: Run with `RUST_BACKTRACE=1` for a backtrace.
  
  
  failures:
      meta::filetype::test::test_socket_type
  
  test result: FAILED. 50 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
  
  error: test failed, to rerun pass '--bin lsd'
@lilyball

This comment has been minimized.

Copy link
Contributor

lilyball commented Mar 15, 2019

I don't have sandbox enabled in my nix.conf. Is there any chance that sandbox builds with a shorter TMPDIR than the default?

@lilyball

This comment has been minimized.

Copy link
Contributor

lilyball commented Mar 15, 2019

env TMPDIR=/tmp nix build -f . lsd succeeded. Seems rather problematic if this can't be built with the default TMPDIR though.

@marsam marsam deleted the marsam:init-lsd branch Mar 15, 2019

@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Mar 15, 2019

That is odd, I'm building it on darwin 10.12 without any issue.

$ nix-build -A lsd
/nix/store/hdmzw3rh86vdsldz44k0k8c5x3vdljbv-lsd-0.13.0

maybe nix-daemon is running with sandbox=true, can you try restarting nix-daemon?

@lilyball

This comment has been minimized.

Copy link
Contributor

lilyball commented Mar 15, 2019

I've got a single-user install so no nix-daemon. This is also why I'm not using sandbox (as the docs says that requires sudo, which I'd prefer not to use).

@lilyball

This comment has been minimized.

Copy link
Contributor

lilyball commented Mar 16, 2019

The simplest solution here might just be to disable tests on this package. I notice the exa package is already doing that:

  # Some tests fail, but Travis ensures a proper build
  doCheck = false;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.