-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unity3d: 2017.4.10f1 -> 2018.3.0f2 #57201
Conversation
@GrahamcOfBorg build unity3d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the team! Please reorder your commits (currently the first commit fails to evaluate since you added yourself to the maintainer list of the package before declaring yourself as a maintainer). Also split the update commit into two, one adding yourself to the maintainer list and one updating the package. The resulting commits should be:
maintainers: add tesq0
unity3d: add tesq0 to the maintainers
unity3d: 2017.4.10f1 -> 2018.3.0f2
@timokau Should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Motivation for this change
Allow people to use a newer version of unity on nixos
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)