Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unity3d: 2017.4.10f1 -> 2018.3.0f2 #57201

Merged
merged 3 commits into from
Apr 11, 2019
Merged

unity3d: 2017.4.10f1 -> 2018.3.0f2 #57201

merged 3 commits into from
Apr 11, 2019

Conversation

tesq0
Copy link
Contributor

@tesq0 tesq0 commented Mar 10, 2019

Motivation for this change

Allow people to use a newer version of unity on nixos

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Assured whether relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 10, 2019
@ryantm
Copy link
Member

ryantm commented Mar 10, 2019

@GrahamcOfBorg build unity3d

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the team! Please reorder your commits (currently the first commit fails to evaluate since you added yourself to the maintainer list of the package before declaring yourself as a maintainer). Also split the update commit into two, one adding yourself to the maintainer list and one updating the package. The resulting commits should be:

  1. maintainers: add tesq0
  2. unity3d: add tesq0 to the maintainers
  3. unity3d: 2017.4.10f1 -> 2018.3.0f2

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 11, 2019
@GrahamcOfBorg GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 11, 2019
@tesq0
Copy link
Contributor Author

tesq0 commented Apr 11, 2019

@timokau Should be good now

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@timokau timokau merged commit 0550927 into NixOS:master Apr 11, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants