Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocat: init at 1.3.0 #57211

Closed
wants to merge 1 commit into from
Closed

websocat: init at 1.3.0 #57211

wants to merge 1 commit into from

Conversation

thoughtpolice
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thoughtpolice
websocat: init at 1.3.0
3ec5823 
Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice self-assigned this Mar 10, 2019
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 10, 2019
srhb
srhb reviewed Mar 10, 2019
View reviewed changes
pkgs/tools/misc/websocat/default.nix
src = fetchFromGitHub {
owner = "vi";
repo = "websocat";
rev = "refs/tags/v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "refs/tags/v${version}";
rev = "v${version}";

... alternatively an explanatory comment for why the release tarball doesn't work? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I simply always use refs/tags -- I was under the impression there's no difference, i.e. that fetchFromGitHub always acquires an archive tarball of some tree snapshot, though I might obviously wrong about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're right and I'm wrong. Thanks. :)

@thoughtpolice
Copy link
Member Author

Closed in 37fe6bf.

@thoughtpolice thoughtpolice deleted the nixpkgs/add-websocat branch March 10, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thoughtpolice @srhb @GrahamcOfBorg