Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 #57266

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@7c6f434c
Copy link
Member

7c6f434c commented Mar 10, 2019

Motivation for this change

LibreOffice update.

Things done

[x] LibreOffice Still: built and executed on x86_64-linux (NixOS-like)

Status

This is the latest LibreOffice update — will probably backport to 19.03 because starting a stable cycle with obsolete LibreOffice Still is unfortunate.

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch from e59682a to 8ed9e7e Mar 10, 2019

@7c6f434c 7c6f434c changed the title libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 [WIP] libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 Mar 10, 2019

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 3 times, most recently from 556e8d8 to 4b939e2 Mar 10, 2019

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Mar 11, 2019

libreoffice-fresh fails a few tests re:odfvalidator? Not sure what's going on there....

Trying libreoffice-still presently... (build build build :))

@7c6f434c

This comment has been minimized.

Copy link
Member Author

7c6f434c commented Mar 11, 2019

@dtzWill Still seems to work for me.

As for Fresh tests: so far I am working on disabling some of them, because 2-pixel rendering problems… (I think even upstream developers sometimes complain about fragileness of some tests). I want most tests to pass, and there are some failures we accept but dislike, but rendering differences are not even disappointing.

But you could have mentioned exact test name so I can kill it too and not wait for my rebuild!

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 4 times, most recently from a1b2d52 to e2ef857 Mar 11, 2019

@7c6f434c

This comment has been minimized.

Copy link
Member Author

7c6f434c commented Mar 12, 2019

ARGGH. Full round-trip import-export-import fails for many entries. Not sure what to do about all that…

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 2 times, most recently from a8564fd to ab56044 Mar 12, 2019

@7c6f434c

This comment has been minimized.

Copy link
Member Author

7c6f434c commented Mar 14, 2019

Status update: LibreOffice Fresh builds, seems to run.

I have disabled way too many tests — the last for lines disable a few classes of tests.

I have no idea how to investigate better and don't have time right now…

(And not updating LibreOffice before stable release is also a bad idea, sigh).

(Deleting my old comments about «progress» in finding a list of tests to disable)

@7c6f434c

This comment has been minimized.

Copy link
Member Author

7c6f434c commented Mar 14, 2019

@lheckemann any preferences regarding handling this LibreOffice update?

@lheckemann

This comment has been minimized.

Copy link
Member

lheckemann commented Mar 15, 2019

Yeah, I'm all for backporting if the current version is obsolete. We can consider the missing tests a bug and just "deal with it" until fixed (if fixed); it's far from the worst, we have 1536 occurrences of doCheck = false; in nixpkgs :/

@7c6f434c 7c6f434c changed the title [WIP] libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 Mar 15, 2019

@7c6f434c 7c6f434c merged commit d8d9a52 into master Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

7c6f434c added a commit that referenced this pull request Mar 15, 2019

Merge pull request #57266 from NixOS/libreoffice-update
libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2
(cherry picked from commit d8d9a52)
@7c6f434c

This comment has been minimized.

Copy link
Member Author

7c6f434c commented Mar 15, 2019

Let;s test this a bit right now then. Backported as c6e6057.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.