Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 #57266

Merged
merged 1 commit into from
Mar 15, 2019
Merged

libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 #57266

merged 1 commit into from
Mar 15, 2019

Conversation

7c6f434c
Copy link
Member

@7c6f434c 7c6f434c commented Mar 10, 2019 •
edited
Loading

Motivation for this change

LibreOffice update.

Things done

[x] LibreOffice Still: built and executed on x86_64-linux (NixOS-like)

Status

This is the latest LibreOffice update — will probably backport to 19.03 because starting a stable cycle with obsolete LibreOffice Still is unfortunate.

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch from e59682a to 8ed9e7e Compare March 10, 2019 17:55
@7c6f434c 7c6f434c changed the title libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 [WIP] libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 Mar 10, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 10, 2019
@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 3 times, most recently from 556e8d8 to 4b939e2 Compare March 11, 2019 05:32
@dtzWill dtzWill mentioned this pull request Mar 11, 2019
Merged
10 tasks
@dtzWill
Copy link
Member

dtzWill commented Mar 11, 2019

libreoffice-fresh fails a few tests re:odfvalidator? Not sure what's going on there....

Trying libreoffice-still presently... (build build build :))

@7c6f434c
Copy link
Member Author

@dtzWill Still seems to work for me.

As for Fresh tests: so far I am working on disabling some of them, because 2-pixel rendering problems… (I think even upstream developers sometimes complain about fragileness of some tests). I want most tests to pass, and there are some failures we accept but dislike, but rendering differences are not even disappointing.

But you could have mentioned exact test name so I can kill it too and not wait for my rebuild!

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 4 times, most recently from a1b2d52 to e2ef857 Compare March 12, 2019 11:15
@7c6f434c
Copy link
Member Author

ARGGH. Full round-trip import-export-import fails for many entries. Not sure what to do about all that…

@7c6f434c 7c6f434c force-pushed the libreoffice-update branch 2 times, most recently from a8564fd to ab56044 Compare March 14, 2019 04:53
@7c6f434c
Copy link
Member Author

Status update: LibreOffice Fresh builds, seems to run.

I have disabled way too many tests — the last for lines disable a few classes of tests.

I have no idea how to investigate better and don't have time right now…

(And not updating LibreOffice before stable release is also a bad idea, sigh).

(Deleting my old comments about «progress» in finding a list of tests to disable)

@7c6f434c
Copy link
Member Author

@lheckemann any preferences regarding handling this LibreOffice update?

@ryantm ryantm added the 2.status: work-in-progress This PR isn't done label Mar 15, 2019
@lheckemann
Copy link
Member

Yeah, I'm all for backporting if the current version is obsolete. We can consider the missing tests a bug and just "deal with it" until fixed (if fixed); it's far from the worst, we have 1536 occurrences of doCheck = false; in nixpkgs :/

@7c6f434c 7c6f434c changed the title [WIP] libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2 Mar 15, 2019
@7c6f434c 7c6f434c merged commit d8d9a52 into master Mar 15, 2019
7c6f434c added a commit that referenced this pull request Mar 15, 2019
@7c6f434c
Merge pull request #57266 from NixOS/libreoffice-update
c6e6057 
libreoffice: 6.1.4.2 -> 6.1.5.2, 6.2.1.2
(cherry picked from commit d8d9a52)
@7c6f434c
Copy link
Member Author

Let;s test this a bit right now then. Backported as c6e6057.

@grahamc grahamc deleted the libreoffice-update branch July 30, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@7c6f434c @dtzWill @lheckemann @ryantm @GrahamcOfBorg