Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHC 8.6.4 #57282

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@pSub
Copy link
Member

pSub commented Mar 10, 2019

Motivation for this change

Add GHC 8.6.4 to release 19.03. This release fixes a bunch of issues (eg. haskell/haddock#979)

This PR cherry-picks commit 68be6bb.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub pSub requested review from basvandijk , peti and ryantm as code owners Mar 10, 2019

@pSub

This comment has been minimized.

Copy link
Member Author

pSub commented Mar 10, 2019

@GrahamcOfBorg GrahamcOfBorg requested a review from kosmikus Mar 10, 2019

@pSub pSub merged commit 779ef93 into release-19.03 Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@pSub pSub deleted the add-ghc-8.6.4 branch Mar 15, 2019

@vaibhavsagar

This comment has been minimized.

Copy link
Contributor

vaibhavsagar commented Mar 15, 2019

Can we also use the latest Stackage LTS that includes GHC 8.6.4: https://www.stackage.org/lts-13.12?

@pSub

This comment has been minimized.

Copy link
Member Author

pSub commented Mar 15, 2019

Sounds reasonable. @peti do you agree?

@peti

This comment has been minimized.

Copy link
Member

peti commented Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.