Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to a few Go packages #57296

Merged
merged 7 commits into from
Mar 11, 2019
Merged

Fixes to a few Go packages #57296

merged 7 commits into from
Mar 11, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 10, 2019 •
edited
Loading

Motivation for this change

In 6ef04ca, the fix was missed for Darwin, and some other packages had the wrong GOCACHE value, working but wrong.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build docker gitlab-shell deepin.go-dbus-generator deepin.go-gir-generator boringssl cadvisor vault

kalbasit referenced this pull request Mar 10, 2019
@kalbasit
go_1_12: init at go 1.12
6ef04ca
@kalbasit kalbasit added the 2.status: work-in-progress This PR isn't done label Mar 10, 2019
@dicarlo2
Copy link

Awesome! Thanks for the quick turnaround :)

kalbasit added 7 commits March 11, 2019 09:59
@kalbasit
docker: export GOCACHE for all platforms
eee09b1
@kalbasit
gitlab-shell: export GOCACHE in the installPhase
483d823 
TMPDIR, in `GOCACHE = "$TMPDIR";`, will not be intepreted  when it's set
outside of a phase.
@kalbasit
deepin.go-dbus-generator: fix the GOCACHE make flag
d925c32
@kalbasit
deepin.go-gir-generator: fix the GOCACHE make flag
f10522d
@kalbasit
boringssl: export GOCACHE in the makeFlags
b39fc3a
@kalbasit
cadvisor: export GOCACHE in the buildPhase
09435db 
TMPDIR, in `GOCACHE = "$TMPDIR";`, will not be intepreted  when it's set
outside of a phase.
@kalbasit
vault: export GOCACHE in the preBuild phase
7cb4e4b 
TMPDIR, in `GOCACHE = "$TMPDIR";`, will not be intepreted  when it's set
outside of a phase.
@kalbasit kalbasit removed the 2.status: work-in-progress This PR isn't done label Mar 11, 2019
@kalbasit kalbasit merged commit c75cb87 into NixOS:master Mar 11, 2019
@kalbasit kalbasit deleted the nixpkgs_go-fixes branch March 11, 2019 20:11
@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

Backported to 18.09 inside #58410, to 19.03 inside #58413.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalbasit @dicarlo2 @flokli @GrahamcOfBorg