Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-vendor: 0.1.13 -> 0.1.23 #57299

Closed
wants to merge 1 commit into from
Closed

cargo-vendor: 0.1.13 -> 0.1.23 #57299

wants to merge 1 commit into from

Conversation

L-as
Copy link
Member

@L-as L-as commented Mar 10, 2019

Motivation for this change

This will make rustPlatform.buildRustPackage work with crates
making use of newer cargo features, such as renaming crates.
In addition, some old hacks were removed from the default
crate overrides.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@L-as
cargo-vendor: 0.1.13 -> 0.1.23
d541bed 
This will make rustPlatform.buildRustPackage work with crates
making use of newer cargo features, such as renaming crates.
In addition, some old hacks were removed from the default
crate overrides.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 10, 2019
@dywedir
Copy link
Member

dywedir commented Mar 10, 2019

Thank you for the contribution!
Please take a look at #57017

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@timokau
Copy link
Member

timokau commented Apr 11, 2019

Closing this since #57017 is older and seems more active. Still thank you for contributing @laas! Feel free to help out at #57017.

@timokau timokau closed this Apr 11, 2019
@L-as
Copy link
Member Author

L-as commented Apr 11, 2019

Thanks, I just forgot to close this myself.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@L-as @dywedir @timokau @infinisil @GrahamcOfBorg @Janik-Haag