Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab fix tar.gz and tar.bz2 archive download #57304

Merged
merged 2 commits into from
Mar 12, 2019
Merged

nixos/gitlab fix tar.gz and tar.bz2 archive download #57304

merged 2 commits into from
Mar 12, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Mar 10, 2019

Motivation for this change

Download of either tar.gz or tar.bz2 archives from any repository fails, because gitaly needs gzip and bzip2 on PATH.

00f7b11 extends the gitlab nixos test to verify downloads of tar.gz and tar.bz2 archives
9376f1d adds the two missing packages to gitaly path

@GrahamcOfBorg test gitlab
cc @globin for review.

Please cherry-pick this to 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@johanot johanot requested a review from infinisil as a code owner March 10, 2019 22:14
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 10, 2019
@globin globin merged commit 292c1ce into NixOS:master Mar 12, 2019
@johanot
Copy link
Contributor Author

johanot commented Mar 12, 2019

@globin Thanks. Want me to open a new PR for 19.03 or will you cherry-pick? :-)

@johanot johanot deleted the gitlab-gitaly-dependencies branch March 12, 2019 22:12
@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

@johanot thanks a lot!

Backported to 18.09 inside #58410, to 19.03 inside #58413.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johanot @flokli @globin @GrahamcOfBorg