ghostscript: link against "systemwide" liblcms2 #57313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GS ships with a fork of lcms2 ("lcms2mt"), but the ABI separation
between the fork and the original seems insufficient. If libgs is linked
alongside liblcms2 (for example, this is the case with imagemagick) then
it will call into the original library instead of the fork, causing
segfaults.
Follow the example of both Arch and Debian in this regard -- they both
use the systemwide lib instead of the fork.
erikarvstedt
approved these changes
Mar 10, 2019
|
I suppose we also should backport this? |
|
@Mic92 👍 |
10 tasks
andersk
added a commit
to andersk/nixpkgs
that referenced
this pull request
Mar 26, 2019
imagemagickBig and imagemagick7Big were marked broken in NixOS#55634 due to NixOS#55118. NixOS#57313 fixed the bug but reverted the broken bit only on imagemagickBig. Revert it on imagemagick7Big too. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
10 tasks
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Mar 27, 2019
imagemagickBig and imagemagick7Big were marked broken in NixOS#55634 due to NixOS#55118. NixOS#57313 fixed the bug but reverted the broken bit only on imagemagickBig. Revert it on imagemagick7Big too. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GS ships with a fork of lcms2 ("lcms2mt"), but the ABI separation
between the fork and the original seems insufficient. If libgs is linked
alongside liblcms2 (for example, this is the case with imagemagick) then
it will call into the original library instead of the fork, causing
segfaults.
Follow the example of both Arch and Debian in this regard -- they both
use the systemwide lib instead of the fork.
Fixes #55118. cc @Mic92 who merged #55634
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)