Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipxe: 20180220 -> 20190310 #57582

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@adamtulinius
Copy link
Contributor

adamtulinius commented Mar 13, 2019

Motivation for this change

This fixes #57581 by updating iPXE to a newer version, which incorporates the patch from https://bugzilla.opensuse.org/show_bug.cgi?id=1105510, which has been upstreamed.

Please cherry-pick to 19.03

Things done

Tested by making a server boot over the network with ipxe

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adamtulinius

This comment has been minimized.

Copy link
Contributor Author

adamtulinius commented Mar 13, 2019

The reason this doesn't fail on hydra, is that the bug is only related to the EFI targets of ipxe. We could change the pkg to build everything, which would cause longer build times, but also catch potential errors like these in the future.

Despite not actually failing, it's probably still related to #56826 :P

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Mar 15, 2019

@GrahamcOfBorg build ipxe

@xeji xeji merged commit d835df0 into NixOS:master Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

xeji added a commit that referenced this pull request Mar 15, 2019

ipxe: 20180220 -> 20190310 (#57582)
(cherry picked from commit d835df0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.