Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parlatype: init at version 1.6-beta #57593

Merged
merged 5 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@melchips
Copy link
Contributor

melchips commented Mar 13, 2019

Motivation for this change

Added package parlatype, a minimal audio player for manual speech transcription, at version v1.6-beta.

Things done

Added package, and myself to maintainers list.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Show resolved Hide resolved pkgs/applications/audio/parlatype/default.nix Outdated
Show resolved Hide resolved pkgs/applications/audio/parlatype/default.nix Outdated
Show resolved Hide resolved pkgs/applications/audio/parlatype/default.nix Outdated
Show resolved Hide resolved pkgs/applications/audio/parlatype/default.nix Outdated
@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Mar 15, 2019

The nixpkgs policy is to package the latest stable release of a package. Can we change the version to 1.5.6 (the latest stable release) for now?

ryantm and others added some commits Mar 15, 2019

Update pkgs/applications/audio/parlatype/default.nix
Removing version from package name.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
Update pkgs/applications/audio/parlatype/default.nix
Removing the leading 'v' on the version attribute.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
Update pkgs/applications/audio/parlatype/default.nix
Using pname as github repository name.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
Update pkgs/applications/audio/parlatype/default.nix
Using tag instead of specific commit revision.

Co-Authored-By: melchips <melchips@users.noreply.github.com>
@melchips

This comment has been minimized.

Copy link
Contributor Author

melchips commented Mar 15, 2019

Thanks @ryantm for those fixes.

The nixpkgs policy is to package the latest stable release of a package. Can we change the version to 1.5.6 (the latest stable release) for now?

Sadly, the build system has been changed between those two versions (autotools to meson).
A final release is planned for April (see https://github.com/gkarsay/parlatype/releases/tag/v1.6-beta)

What would be the best course of action ?

  • wait for the stable release in April and submit another pull request
  • submit this package to the unstable channel instead
  • try to port the current stable version

Thanks for your input ^^

@ryantm

ryantm approved these changes Mar 15, 2019

@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Mar 15, 2019

  • submit this package to the unstable channel instead

Merges to the master branch are what ends up in the unstable channel after they are built by Hydra.

If we already had parlatype in nixpkgs, I would say wait until April for the stable release, but since we don't have it packaged, it seems like the most value we can get out of our work would be to merge this and then do a separate PR to update to the stable version in April.

@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Mar 15, 2019

@GrahamcOfBorg build parlatype

@ryantm ryantm merged commit a9bbf7b into NixOS:master Mar 15, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.