Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.weboob: add pyqt5 as native input #57653

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@worldofpeace
Copy link
Member

worldofpeace commented Mar 14, 2019

Motivation for this change

Address @dotlambda feedback for #57555 after merge

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pythonPackages.weboob: add pyqt5 as native input
Didn't notice it wasn't there. This should make it so we
don't have to set the environment variable anymore.

@worldofpeace worldofpeace requested a review from dotlambda Mar 14, 2019

@worldofpeace worldofpeace requested a review from FRidh as a code owner Mar 14, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 14, 2019

Port to stable so since the last change fixed build, and this makes things nicer.

@dotlambda dotlambda force-pushed the worldofpeace:google-api-python-client branch from 50fc89c to fb2af2a Mar 15, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Mar 15, 2019

I changed it a tiny bit by using old.src.override.

@dotlambda dotlambda merged commit 6339f0b into NixOS:master Mar 15, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Mar 15, 2019

cherry picked in 497b023 and 9fa2a21

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 15, 2019

I changed it a tiny bit by using old.src.override.

Nice, more people should do it like that 👍

@worldofpeace worldofpeace deleted the worldofpeace:google-api-python-client branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.