Skip to content

flat-remix-icon-theme: init at 20191018 #57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2019
Merged

flat-remix-icon-theme: init at 20191018 #57659

merged 2 commits into from
Nov 27, 2019

Conversation

feijoas
Copy link
Contributor

@feijoas feijoas commented Mar 14, 2019

Motivation for this change

Added the flat-remix-icon-theme

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Mar 28, 2019
View reviewed changes
@feijoas feijoas force-pushed the flat-remix-icon-theme branch from 754a4b4 to f1c62c8 Compare March 29, 2019 17:59
@infinisil
Copy link
Member

The commits should be the other way around though, how it is now, you reference maintainers.mschneider before it actually exists

@feijoas feijoas force-pushed the flat-remix-icon-theme branch from f1c62c8 to 86ff956 Compare March 29, 2019 18:52
@feijoas
Copy link
Contributor Author

feijoas commented Mar 29, 2019

Changed the order of commits.

@infinisil
Copy link
Member

@GrahamcOfBorg build flat-remix-icon-theme

@feijoas
Copy link
Contributor Author

feijoas commented Apr 8, 2019

Why is the hash on darwin different?

@feijoas feijoas force-pushed the flat-remix-icon-theme branch 2 times, most recently from a5a89ef to fb9a76c Compare November 26, 2019 20:59
@feijoas feijoas changed the title flat-remix-icon-theme: init at 2019-03-14 flat-remix-icon-theme: init at 20191018 Nov 26, 2019
@feijoas feijoas requested a review from infinisil November 26, 2019 21:01
@feijoas feijoas force-pushed the flat-remix-icon-theme branch from fb9a76c to 7f77cf1 Compare November 27, 2019 17:04
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 27, 2019

@GrahamcOfBorg build flat-remix-icon-theme

@feijoas @c0bw3b
Update pkgs/data/icons/flat-remix-icon-theme/default.nix
8b2e167 
Co-Authored-By: Renaud <c0bw3b@users.noreply.github.com>
@c0bw3b c0bw3b merged commit 4ee137e into NixOS:master Nov 27, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 3, 2020
@feijoas @dtzWill
flat-remix-icon-theme: init at 20191018
0cdaeb3 
(NixOS#57659)

(cherry picked from commit 4ee137e)
@feijoas feijoas deleted the flat-remix-icon-theme branch April 3, 2020 06:57
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@feijoas @infinisil @c0bw3b @GrahamcOfBorg @Janik-Haag @mschneiderwng