Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: make x11 optional, disabled on darwin #57685

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jacereda
Copy link
Contributor

jacereda commented Mar 15, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c

This comment has been minimized.

Copy link
Member

7c6f434c commented Mar 15, 2019

Not completely sure if not having X11 support is a good macOS default — and in any case this changes dependency order, which implies a rebuild even on Linux, so it should be retargeted to staging

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Mar 15, 2019

We are updating pango in #57027, is this change compatible?

@7c6f434c

This comment has been minimized.

Copy link
Member

7c6f434c commented Mar 15, 2019

Substantially yes, but automatic merge will produce a conflict (both add some conditional build inputs, both change the argument list).

@jtojnar jtojnar requested a review from hedning Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.