Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modemmanager: 1.7.990 -> 1.10.0 #57689

Merged
merged 3 commits into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@worldofpeace
Copy link
Member

worldofpeace commented Mar 15, 2019

Motivation for this change

Fix #57615

I still need to give the News items a better look.

Probably should add multiple outputs for modemmanager?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (master)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace force-pushed the worldofpeace:ModemManager/bump branch from 93f3110 to 013f591 Mar 15, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 15, 2019

Think I did all the things, just need to verify that we actually fixed #41055 by linking the service relatively.

@worldofpeace worldofpeace force-pushed the worldofpeace:ModemManager/bump branch from 013f591 to ce1824b Mar 15, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 15, 2019

Still see the issue described at #41055 (comment) so I'm not going to link it relatively.

@worldofpeace worldofpeace force-pushed the worldofpeace:ModemManager/bump branch from ce1824b to 7a74201 Mar 15, 2019

@worldofpeace worldofpeace force-pushed the worldofpeace:ModemManager/bump branch from 7a74201 to 20b5b26 Mar 15, 2019

worldofpeace added some commits Mar 15, 2019

libqmi: 1.20.2 -> 1.22.2
Drop --enable-mbim-qmux because we have libmbim >= 1.14.0 [0]

[0]: https://gitlab.freedesktop.org/mobile-broadband/libqmi/blob/1.16.0/NEWS#L5
modemmanager: 1.7.990 -> 1.10.0
* Add flags for systemd [0]

* Enable tests
  Though I actually didn't look to see how they're
  performed, only effort done was to get a success-
  ful build.

* Enable vala bindings

[0]: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/blob/1.8.0/NEWS#L21

@worldofpeace worldofpeace force-pushed the worldofpeace:ModemManager/bump branch from 20b5b26 to cb962e8 Mar 15, 2019

@worldofpeace worldofpeace requested a review from jtojnar Mar 18, 2019

@jtojnar
Copy link
Contributor

jtojnar left a comment

Thank you very much for taking care of this.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 18, 2019

Thanks. Feel free to open more issues for things you'd like taken care of.

@worldofpeace worldofpeace merged commit d22aeb0 into NixOS:staging Mar 18, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@worldofpeace worldofpeace deleted the worldofpeace:ModemManager/bump branch Mar 18, 2019

@worldofpeace worldofpeace referenced this pull request Mar 19, 2019

Merged

Networkmanager: rename service to match upstream #51382

4 of 10 tasks complete
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Mar 20, 2019

@jtojnar should/can this be backported to 19.03 as well?

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Mar 20, 2019

Probably should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.