Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vala updates #57709

Merged
merged 9 commits into from Mar 18, 2019

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Mar 15, 2019

Motivation for this change

#57027

I feel like we have maybe one too many compiler versions here, so I'd like to know which one would be acceptable for removal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Mar 15, 2019

Upstream usually supports three most recent branches so ideally, we would not keep more than these. Personally, I would just keep the latest branch but elementary probably depends on the ancient version in Ubuntu LTS and we also have a lot of Vala abandonware, so we might not afford to drop that much yet.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 15, 2019

Upstream usually supports three most recent branches so ideally, we would not keep more than these.

Exactly, hence my confusion in us keeping more than these

Personally, I would just keep the latest branch but elementary probably depends on the ancient version in Ubuntu LTS

They actually, at least recently, push fixes for any breakage that they notice will happen with the latest vala. Ubuntu LTS is at 0.40 but we should be able to use 0.44 for Pantheon.

Only thing that could be a large annoyance is the "third party apps" are tested against 0.40 so they'll slowly break as the LTS goes by.

@worldofpeace worldofpeace force-pushed the worldofpeace:vala-updates/03-2019 branch from 884e59c to 34031e9 Mar 18, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 18, 2019

I've corrected the patches and added a patch so libhttpseverywhere can build with latest vala.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Mar 18, 2019

@jtojnar I should merge this into the gnome branch?

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Mar 18, 2019

I would just merge it to staging. And rebase gnome-3.32 onto that (since we already want that for gdk-pixbuf).

@worldofpeace worldofpeace force-pushed the worldofpeace:vala-updates/03-2019 branch from 34031e9 to 1727324 Mar 18, 2019

@worldofpeace worldofpeace changed the base branch from master to staging Mar 18, 2019

@worldofpeace worldofpeace merged commit f102c30 into NixOS:staging Mar 18, 2019

1 check was pending

grahamcofborg-eval Checking original out paths
Details

@worldofpeace worldofpeace deleted the worldofpeace:vala-updates/03-2019 branch Mar 18, 2019

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Mar 18, 2019

Should this use callPackages at the top-level?

@jtojnar

This comment has been minimized.

Copy link
Contributor

jtojnar commented Mar 18, 2019

Possibly, I am not sure what the difference is though.

Also, it would be nice if we could make updateScript work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.