Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qiv: 2.3.1 -> 2.3.2 #57729

Merged
merged 1 commit into from
Mar 16, 2019
Merged

qiv: 2.3.1 -> 2.3.2 #57729

merged 1 commit into from
Mar 16, 2019

Conversation

fare
Copy link
Contributor

@fare fare commented Mar 15, 2019

Motivation for this change

Upstream release.

Note that this update of qiv does not fix issue #54278 whereby qiv segfaults on JPEG or PNG since upgrading gdk_pixbuf from 2.36.12 to 2.38.0 (and doesn't just work with 2.38.1 from #57027 either). But it updates qiv nonetheless, that still works on GIF pictures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 15, 2019
@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

@GrahamcOfBorg build qiv

@xeji xeji merged commit 4b00757 into NixOS:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants